This repository has been archived by the owner on Apr 24, 2024. It is now read-only.
feat: React workspaces and css loaders #323
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋
First of all thanks for building this out, it's been quite helpful
This PR introduces two changes that I needed, and I think some people in the community needed:
Introduce a new config flag
use-react-workspaces@react-workspaces/react-scriptsversions ofreact-scripts@react-workspaces/to everywhere you previously usedreact-scriptsAdd in
MiniCssExtractPluginwhich will bundle any CSS files imported in a react component such asindex.htmls<head>sectionstyle-loaderwhich I believe appends it at run-time usingwindowI understand that these changes might not suit the overall direction of the project, particularly because introducing
MiniCssExtractPluginintroduces an explicit dependency on a webpack version (if someone can tell me how to get around that it would be even betterIf you think I should split these changes up I will happily do that too, I was just solving my own problems as I went and figured it would be best to contribute back.
Thanks again