Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added better verification message #216

Merged
merged 1 commit into from
Jul 6, 2021
Merged

Added better verification message #216

merged 1 commit into from
Jul 6, 2021

Conversation

mikeporterdev
Copy link
Contributor

Duplicated a feature from @johanblumenbergs fork into ts-mockito.
Shows a better log message on verify failures to explain the actual calls that were made

Example
image

@mikeporterdev
Copy link
Contributor Author

Johan's fork didn't seem to have a PR open for this feature so I've opened one up. This is a huge addition to the usefulness of this library and I think should be the main priority for new features to be merged in following the discussion in #212

@codecov-commenter
Copy link

Codecov Report

Merging #216 (a1be0e5) into master (0b18158) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
+ Coverage   93.56%   93.62%   +0.05%     
==========================================
  Files          34       34              
  Lines         653      659       +6     
  Branches       80       80              
==========================================
+ Hits          611      617       +6     
  Misses         29       29              
  Partials       13       13              
Impacted Files Coverage Δ
src/MethodStubVerificator.ts 100.00% <100.00%> (ø)
src/utils/MethodCallToStringConverter.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b18158...a1be0e5. Read the comment docs.

@NagRock
Copy link
Owner

NagRock commented Jul 6, 2021

@johanblumenberg FYI

@NagRock NagRock merged commit 89ce91b into NagRock:master Jul 6, 2021
@mikeporterdev
Copy link
Contributor Author

@NagRock this was merged but is it possible to get this deployed, have been waiting for this to roll out for a while

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants