Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid shadowing python builtin in tile matmul example #495

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

scal444
Copy link

@scal444 scal444 commented Feb 4, 2025

Category

  • New feature
  • Bugfix
  • Breaking change
  • Refactoring
  • Documentation
  • Other (please explain)

Description

In docs, this was rendering a different color than expected because the interpreter picks out sum as a builtin. Seen here

Changelog

Before your PR is "Ready for review"

  • [ x] Do you agree to the terms under which contributions are accepted as described in Section 9 the Warp License?
  • [x ] Necessary tests have been added
  • [ x] Documentation is up-to-date
  • [ x] Auto-generated files modified by compiling Warp and building the documentation have been updated (e.g. stubs.py, functions.rst)
  • [ x] Code passes ruff check and ruff format --check?

In docs, this was rendering a different color than expected because the interpreter picks out `sum` as a builtin.
@shi-eric
Copy link
Contributor

shi-eric commented Feb 4, 2025

Thanks, can you open this MR on the internal repo instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants