Fix tree topology output #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ritika Srivastava <[email protected]>
ritikasrivastava
requested review from
dmitsh and
sanjaychatterjee
as code owners
dmitsh
reviewed
Dec 16, 2024
| @@ -95,67 +93,96 @@ func getIbTree(ctx context.Context, _ []string) (*topology.Vertex, error) { | |||
| ibKey := ibPrefix + strconv.Itoa(ibCount) | |||
| treeRoot.Vertices[ibKey] = ibRoot | |||
| break | |||
| } else { | |||
| fmt.Printf("Missing ibnetdiscover output\n") | |||
There was a problem hiding this comment.
Should we use log instead?
Do we need to return error?
Do we need to have a metric for this error?
There was a problem hiding this comment.
I am not sure about this. It is not really an error scenario if IB is not present. This text is supposed to be informational. Should we remove it instead?
Signed-off-by: Ritika Srivastava <[email protected]>
dmitsh
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.