add 'reconfigure' to unit-tests and update script (#44)

Signed-off-by: Dmitry Shmulevich <[email protected]>
NVIDIA · Dec 9, 2024 · 6e93350 · 6e93350
1 parent 581932c
commit 6e93350
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/pkg/topology/request.go b/pkg/topology/request.go
@@ -138,7 +138,7 @@ func mapOfAny2string(m map[string]any, prefix string, hide bool, suffix string)
 			if hide {
 				terms = append(terms, fmt.Sprintf("%s:***", key))
 			} else {
-				terms = append(terms, fmt.Sprintf("%s:%s", key, m[key]))
+				terms = append(terms, fmt.Sprintf("%s:%v", key, m[key]))
 			}
 		}
 		sb.WriteString(strings.Join(terms, " "))

diff --git a/pkg/topology/request_test.go b/pkg/topology/request_test.go
@@ -67,7 +67,8 @@ func TestPayload(t *testing.T) {
     "name": "slurm",
 	"params": {
 	  "plugin": "topology/block",
-	  "block_sizes": "30,120"
+	  "block_sizes": "30,120",
+	  "reconfigure": true
 	}
   },
   "nodes": [
@@ -104,6 +105,7 @@ func TestPayload(t *testing.T) {
 					Params: map[string]any{
 						topology.KeyPlugin:     topology.TopologyBlock,
 						topology.KeyBlockSizes: "30,120",
+						"reconfigure":          true,
 					},
 				},
 				Nodes: []topology.ComputeInstances{
@@ -130,7 +132,7 @@ func TestPayload(t *testing.T) {
   Credentials: [access_key_id:*** secret_access_key:***]
   Parameters: []
   Engine: slurm
-  Parameters: [block_sizes:30,120 plugin:topology/block]
+  Parameters: [block_sizes:30,120 plugin:topology/block reconfigure:true]
   Nodes: region1: [instance1:node1 instance2:node2 instance3:node3] region2: [instance4:node4 instance5:node5 instance6:node6]
 `,
 		},

diff --git a/scripts/create-topology-update-script.sh b/scripts/create-topology-update-script.sh
@@ -95,7 +95,7 @@ echo ""
 cat <<EOF > $SCRIPT_PATH
 #!/bin/bash
 
-curl -X POST -H "Content-Type: application/json" -d '{"provider":{"name":"$PROVIDER"},"engine":{"name":"slurm","params":{"topology_config_path":"$TOPOLOGY_CONFIG_PATH"}}}' http://localhost:49021/v1/generate
+curl -X POST -H "Content-Type: application/json" -d '{"provider":{"name":"$PROVIDER"},"engine":{"name":"slurm","params":{"topology_config_path":"$TOPOLOGY_CONFIG_PATH","reconfigure":true}}}' http://localhost:49021/v1/generate
 EOF
 
 chmod 755 $SCRIPT_PATH