Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix future warnings for pandas>=2.2 #1494

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Fix future warnings for pandas>=2.2 #1494

merged 2 commits into from
Jan 10, 2025

Conversation

leewyang
Copy link
Collaborator

This PR fixes #1490.

  • Resolves FutureWarning messages when running qualification with pandas>=2.2 by using new form of df.method({col: value}, inplace=True) for df.fillna() calls.
  • Resolves SettingWithCopyWarning by making an explicit copy of input dataframe before modification.

@leewyang leewyang added the user_tools Scope the wrapper module running CSP, QualX, and reports (python) label Jan 10, 2025
@leewyang leewyang self-assigned this Jan 10, 2025
@leewyang
Copy link
Collaborator Author

@parthosa for the SettingWithCopyWarning fix, I wasn't absolutely sure if the modifications to the output_df within the _generate_output_table() function were intended to persist after the function exit. Can you confirm if the fix is ok?

parthosa
parthosa approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@parthosa parthosa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @leewyang for this. I confirmed the changes LGTME.

@leewyang leewyang merged commit bb048d0 into NVIDIA:dev Jan 10, 2025
13 checks passed
@leewyang leewyang deleted the qualx_fix_warnings branch January 10, 2025 01:28
@leewyang leewyang mentioned this pull request Jan 11, 2025
Merged
leewyang added a commit that referenced this pull request Jan 11, 2025
@leewyang
Fix additional FutureWarning issues (#1499)
5745ea5 
This PR is a followup to #1494 to resolve additional warnings found
during the `qualx evaluate` command.

Confirmed that the evaluation results are identical before/after these
changes.

Signed-off-by: Lee Yang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthosa parthosa parthosa approved these changes

@amahussein amahussein Awaiting requested review from amahussein

Assignees

@leewyang leewyang

Labels
user_tools Scope the wrapper module running CSP, QualX, and reports (python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Cleanup FutureWarning generated by pandas in the user-tools output
2 participants
@leewyang @parthosa