Make spill heuristic 1 TB by default #1488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kuhu Shukla <[email protected]>
Signed-off-by: Kuhu Shukla <[email protected]>
amahussein
approved these changes
Jan 7, 2025
amahussein
added
the
user_tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1415 by putting a band aid. We can keep this issue open for the better algorithm recommended in the description of the issue. The goal of this change is to unblock difficulties with user experience of this low value heuristic. I understand that a perfect value is not trivial as just moving this value from 10 GB to 1 TB , however, this alleviates the need for SAs to tune this from the get go and also is more explainable to customers. Appreciate comments. Marking as WIP until I have tools team's blessing on the band aid.