Support group-limit optimization for ROW_NUMBER in Qualification #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmed Hussein (amahussein) <[email protected]> Fixes NVIDIA#1484 This code adds the `row_number` to the list of supported expressions in `WindowGroupLimit`. Update the unit-tests to verify that the behavior is as expected.
amahussein
added
feature request
parthosa
reviewed
Jan 3, 2025
core/src/main/scala/com/nvidia/spark/rapids/tool/planparser/WindowGroupLimitParser.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/com/nvidia/spark/rapids/tool/planparser/SqlPlanParserSuite.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>
parthosa
approved these changes
Jan 3, 2025
nartal1
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ahmed Hussein (amahussein) [email protected]
Fixes #1484
This code adds the
row_numberto the list of supported expressions inWindowGroupLimit.Update the unit-tests to verify that the behavior is as expected.
Detailed Changes
This pull request includes updates to the
WindowGroupLimitParserand its corresponding test suite to support therow_numberexpression. Additionally, it includes some refactoring to simplify the test cases.Support for
row_numberexpression:core/src/main/scala/com/nvidia/spark/rapids/tool/planparser/WindowGroupLimitParser.scala: Addedrow_numberto the set of supported ranking expressions.Refactoring of test cases:
core/src/test/scala/com/nvidia/spark/rapids/tool/planparser/SqlPlanParserSuite.scala: Introduced a helper methodrunWindowGroupLimitTestto streamline test cases forWindowGroupLimitexpressions. Updated existing test cases to use this helper method. [1] [2] [3]