Refine Qualification AutoTuner recommendations for shuffle partitions for CPU event logs #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Partho Sarthi <[email protected]>
parthosa
added
bug
amahussein
approved these changes
Dec 31, 2024
| * List of recommendations for which the Qualification AutoTuner skips calculations and only | ||
| * depend on default values. | ||
| */ | ||
| override protected val limitedLogicRecommendations: mutable.HashSet[String] = mutable.HashSet( |
There was a problem hiding this comment.
QQ:
It is expected that limitedLogicRecommendations to be platform specific.
Is it going to be feasible to do change behavior based on platform when needed in the future?
There was a problem hiding this comment.
Yes, we could use a similar class based approach (say PlatformSpecificAutoTunerProvider) to provide any platform specific tunings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1400.
This PR updates the Qualification AutoTuner to recommend setting shuffle partitions to 200 when processing CPU event logs. For GPU event logs, the existing logic in the Profiling AutoTuner remains unchanged.
Changes
Improvements to
AutoTuner:limitedLogicRecommendationsfrom private to protected to allow subclass access.shuffleStagesWithPosSpillinginside a conditional block to avoid unnecessary computations.Enhancements to
QualificationAutoTuner:limitedLogicRecommendationsinQualificationAutoTunerto includespark.sql.shuffle.partitions.Tests
buildDefaultAutoTunerinQualificationAutoTunerSuiteto create instances with default properties.QualificationAutoTunersets shuffle partitions to 200.