Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Fix sync plugin files script to handle empty or non-existing cvs files #1446

Merged
merged 1 commit into from
Dec 5, 2024
Merged

[BUG] Fix sync plugin files script to handle empty or non-existing cvs files #1446

merged 1 commit into from
Dec 5, 2024

Conversation

cindyyuanjiang
Copy link
Collaborator

Fixes #1445

Changes

@cindyyuanjiang
fix issue with empty file
5960bbe 
Signed-off-by: cindyyuanjiang <[email protected]>
@cindyyuanjiang cindyyuanjiang self-assigned this Dec 4, 2024
@cindyyuanjiang cindyyuanjiang added bug Something isn't working dependencies Pull requests that update a dependency file labels Dec 4, 2024
nartal1
nartal1 approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@nartal1 nartal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cindyyuanjiang ! LGTM.

@cindyyuanjiang cindyyuanjiang merged commit a414e09 into NVIDIA:dev Dec 5, 2024
16 checks passed
@cindyyuanjiang cindyyuanjiang deleted the spark-rapids-tools-1445 branch December 5, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nartal1 nartal1 nartal1 approved these changes

@parthosa parthosa Awaiting requested review from parthosa

@amahussein amahussein Awaiting requested review from amahussein

Assignees

@cindyyuanjiang cindyyuanjiang

Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Sync plugin files script throws an exception when input csv file is empty
2 participants
@cindyyuanjiang @nartal1