Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Arguments for Distributed Mode in Qualification Tool CLI #1428

Conversation

parthosa
Copy link
Collaborator

This PR add arguments to enable distributed tools for qualification tool.

Changes

  • Extended RapidsJob: Introduced two subclasses—RapidsDistributedJob and RapidsLocalJob and a concrete class for the OnPrem platform.
  • Created a JarCmdArgs class to encapsulate all arguments needed to construct the JAR command.
  • Implemented the DistributedToolsConfig class, allowing configurations for distributed tools (like Spark properties) to be specified via the --tools_config_file option.

Example

CMD:

spark_rapids qualification --platform onprem --eventlogs /path/to/eventlogs  --verbose --filter_apps all \
 --distributed --tools_config_file /path/to/custom_conf_file.yaml

Sample Config File:

api_version: '1.0'
distributed_tools:
  spark_properties:
    - name: 'spark.executor.memory'
      value: '20g'

Details:

Enhancements to argument processing:

Platform class updates:

  • user_tools/src/spark_rapids_pytools/cloud_api/databricks_aws.py, databricks_azure.py, dataproc.py, dataproc_gke.py, emr.py: Disabled pylint warnings for abstract methods. [1] [2] [3] [4] [5]

Other improvements:

Signed-off-by: Partho Sarthi <[email protected]>
Signed-off-by: Partho Sarthi <[email protected]>
Signed-off-by: Partho Sarthi <[email protected]>
@parthosa parthosa added feature request New feature or request user_tools Scope the wrapper module running CSP, QualX, and reports (python) labels Nov 18, 2024
@parthosa parthosa self-assigned this Nov 18, 2024
Signed-off-by: Partho Sarthi <[email protected]>
@parthosa parthosa closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request user_tools Scope the wrapper module running CSP, QualX, and reports (python)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant