Changing autotuner memory error to warning in comments #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mattahrens <[email protected]>
…ating unit tests Signed-off-by: mattahrens <[email protected]>
parthosa
previously approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Thanks @mattahrens for making this change. I was also thinking we should change this to warn as it could cause issue with internal testing team as well.
amahussein
previously approved these changes
Nov 13, 2024
amahussein
reviewed
Nov 13, 2024
| val msg = "This node/worker configuration is not ideal for using the Spark Rapids " + | ||
| "Accelerator because it doesn't have enough memory for the executors. " + | ||
| val msg = "This node/worker configuration is not ideal for using the Spark Rapids \n" + | ||
| "Accelerator because it doesn't have enough memory for the executors. \n" + |
There was a problem hiding this comment.
nit: trailing space before the \n
There was a problem hiding this comment.
updated in latest commit
| // in the future it would be nice to enhance the error message with a recommendation of size | ||
| val msg = "This node/worker configuration is not ideal for using the Spark Rapids " + | ||
| "Accelerator because it doesn't have enough memory for the executors. " + | ||
| val msg = "This node/worker configuration is not ideal for using the Spark Rapids \n" + |
There was a problem hiding this comment.
nit: trailing space before the \n
There was a problem hiding this comment.
updated in latest commit
Signed-off-by: mattahrens <[email protected]>
parthosa
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1314