Remove estimated GPU duration from qualification output #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmed Hussein <[email protected]> Fixes NVIDIA#1411 Removes two columns from the core qualification's output `Estimated GPU Duration` and `Estimated GPU Time Saved` from 2 files `rapids_4_spark_qualification_output.csv` and `rapids_4_spark_qualification_output_persql.csv`
amahussein
added
core_tools
|
Found that I mistakenly removed the quotes from the CSV files |
Signed-off-by: Ahmed Hussein <[email protected]>
parthosa
reviewed
Nov 5, 2024
There was a problem hiding this comment.
Thanks @amahussein. QQ: How do we update the expectation files beside running the tools for each of them? Do we have a script to update the expectation files?
core/src/main/scala/org/apache/spark/sql/rapids/tool/qualification/QualificationAppInfo.scala
Show resolved
Hide resolved
core/src/test/scala/com/nvidia/spark/rapids/tool/qualification/QualificationSuite.scala
Show resolved
Hide resolved
Signed-off-by: Ahmed Hussein <[email protected]>
parthosa
previously approved these changes
Nov 5, 2024
Thanks @parthosa |
Signed-off-by: Ahmed Hussein <[email protected]>
parthosa
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ahmed Hussein [email protected]
Fixes #1411
Removes two columns from the core qualification's output
Estimated GPU DurationandEstimated GPU Time Savedfrom 2 filesrapids_4_spark_qualification_output.csvandrapids_4_spark_qualification_output_persql.csv