Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Support group-limit optimization for ROW_NUMBER in Qualification #1484

Closed
amahussein opened this issue Jan 3, 2025 · 0 comments · Fixed by #1487
Closed

[FEA] Support group-limit optimization for ROW_NUMBER in Qualification #1484

amahussein opened this issue Jan 3, 2025 · 0 comments · Fixed by #1487
Assignees
@amahussein
Labels
core_tools Scope the core module (scala) feature request New feature or request

Comments

@amahussein
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

NVIDIA/spark-rapids@6244613 added support to ROW_NUMBER.
Since this is not tracked in the supported CSV files, we need to manually update the implementation of WindowGroupLimitParser to follow suit.
@amahussein amahussein added ? - Needs Triage core_tools Scope the core module (scala) feature request New feature or request labels Jan 3, 2025
@amahussein amahussein self-assigned this Jan 3, 2025
amahussein added a commit to amahussein/spark-rapids-tools that referenced this issue Jan 3, 2025
@amahussein
Support group-limit optimization for ROW_NUMBER in Qualification
502087f 
Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>

Fixes NVIDIA#1484

This code adds the `row_number` to the list of supported expressions in
`WindowGroupLimit`.
Update the unit-tests to verify that the behavior is as expected.
@amahussein amahussein mentioned this issue Jan 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amahussein amahussein

Labels
core_tools Scope the core module (scala) feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support group-limit optimization for ROW_NUMBER in Qualification amahussein/spark-rapids-tools
1 participant
@amahussein