Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove estimated GPU duration from qualification output #1411

Closed
Tracked by #1221
amahussein opened this issue Nov 5, 2024 · 0 comments · Fixed by #1412
Closed
Tracked by #1221

Remove estimated GPU duration from qualification output #1411

amahussein opened this issue Nov 5, 2024 · 0 comments · Fixed by #1412
Assignees
@amahussein
Labels
API change A changeA change affecting the output (add/remove/rename files, add/remove/rename columns) core_tools Scope the core module (scala)

Comments

@amahussein
Copy link
Collaborator

amahussein commented Nov 5, 2024 •
edited
Loading

As part of removing the legacy output calculation that depends on the legacy speedups, we need to get rid of the estimated GPU durations in different CSV files

  • rapids_4_spark_qualification_output.csv
    • Estimated GPU Duration
    • Estimated GPU Time Saved
  • rapids_4_spark_qualification_output_persql.csv
    • Estimated GPU Duration
    • Estimated GPU Time Saved
@amahussein amahussein added API change A changeA change affecting the output (add/remove/rename files, add/remove/rename columns) core_tools Scope the core module (scala) labels Nov 5, 2024
@amahussein amahussein self-assigned this Nov 5, 2024
@amahussein amahussein mentioned this issue Nov 5, 2024
Open
amahussein added a commit to amahussein/spark-rapids-tools that referenced this issue Nov 5, 2024
@amahussein
Remove estimated GPU duration from qualification output
627f5f6 
Signed-off-by: Ahmed Hussein <[email protected]>

Fixes NVIDIA#1411

Removes two columns from the core qualification's output
`Estimated GPU Duration` and `Estimated GPU Time Saved` from 2 files `rapids_4_spark_qualification_output.csv` and `rapids_4_spark_qualification_output_persql.csv`
@amahussein amahussein mentioned this issue Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amahussein amahussein

Labels
API change A changeA change affecting the output (add/remove/rename files, add/remove/rename columns) core_tools Scope the core module (scala)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove estimated GPU duration from qualification output amahussein/spark-rapids-tools
1 participant
@amahussein