Fix streaming and threshold #672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randerzander
requested changes
Apr 22, 2025
| secret_key: str = "minioadmin", | ||
| bucket_name: str = "a-bucket", | ||
| threshold: int = 10, | ||
| threshold: int = 50, |
Collaborator
There was a problem hiding this comment.
Suggested change
| threshold: int = 50, | |
| threshold: int = 1000, |
when testing w/ bo20, there are 812 chunks. with stream=True, total runtime goes from 114 to 76s
Seems like the threshold should be higher, which gives a nice perf lift for smaller ingest jobs
edknv
approved these changes
Apr 22, 2025
Collaborator
edknv
left a comment
edknv
left a comment
There was a problem hiding this comment.
Changes look good to me. I think we can ignore the failing integration test; I don't see how this PR fails the integration test, and it's probably due to some unrelated issues with the build endpoint. However, there is one unit test that is failing and needs updating before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes how streaming is auto activated. It now checks the count of how many elements (chunks) are processed. The threshold has been increased to 50 given this change. And we also plumbed the stream parameter so you can activate streaming insert to milvus regardless of the number of elements.
Checklist