Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clientsets for NIM Operator custom CRDs #9

Closed
wants to merge 34 commits into from
Closed

Add clientsets for NIM Operator custom CRDs #9

wants to merge 34 commits into from

Conversation

shivamerla
Copy link
Collaborator

No description provided.

shivamerla and others added 23 commits July 30, 2024 11:26
@shivamerla
Add support to deploy NIMs on Kubernetes and OpenShift
fe0184e 
Signed-off-by: Shiva Krishna, Merla <[email protected]>
@shivamerla
Update README.md
9743100
@shivamerla
Update NIMProfile Spec
73629be 
Signed-off-by: Shiva Krishna, Merla <[email protected]>
@shivamerla
Merge pull request #1 from NVIDIA/master
1eb4682 
Update NIMProfile Spec
@shivamerla
Update README.md
5cef34c
@shivamerla
Update values.yaml
cea832e
@shivamerla
Update k8s-nim-operator.clusterserviceversion.yaml
4af426a
@shivamerla
Update the NIM service to use anyuid SCC and misc fixes for creation …
2a5c308 
…of new scc

Signed-off-by: Shiva Krishna, Merla <[email protected]>
@shivamerla
Merge pull request #2 from NVIDIA/master
e6d114c 
Update the NIM service to use anyuid SCC and misc fixes for creation …
@shivamerla
Update NIMPipeline spec
5e1201a 
Signed-off-by: Shiva Krishna, Merla <[email protected]>
@ArangoGutierrez
Merge pull request #3 from NVIDIA/update_nimpipeline_spec
6d4248b 
Update NIMPipeline spec
@shivamerla
Cleanup Embedding/ReRanking CRDs as they are types with the NIMServic…
5bd629c 
…e itself

Signed-off-by: Shiva Krishna, Merla <[email protected]>
@shivamerla
Update bundle/helm folders
5c5670d 
Signed-off-by: Shiva Krishna, Merla <[email protected]>
@shivamerla
Rebase
12b9d19 
Signed-off-by: Shiva Krishna, Merla <[email protected]>
@ArangoGutierrez
Merge pull request #4 from NVIDIA/cleanup_unused_crds
d1fe748 
Cleanup Embedding/ReRanking CRDs as they are types with the NIMService itself
@shivamerla
Update README.md
ed20b61
@visheshtanksale
Adding support for HorizontalPodAutoscaling for NIM deployment
a88ad0e
@visheshtanksale
Updating HPA spec
40b24fc
@shivamerla
Update CODEOWNERS
7b3f4e0
@shivamerla
Merge pull request #6 from NVIDIA/shivamerla-patch-1
8b1ccdc 
Update CODEOWNERS
@shivamerla
Merge pull request #5 from NVIDIA/HPA-support
ebf9f39 
Adding support for HorizontalPodAutoscaling for NIM deployment
@shivamerla
Refactor NIMCache as it is platform independent (#7)
52ab808 
Signed-off-by: Shiva Krishna, Merla <[email protected]>
@visheshtanksale
Adding support for creating ingress for NIM Deployment (#8)
848b788
@shivamerla
Copy link
Collaborator Author 

~/git/src/github.com/NVIDIA/k8s-nim-operator$ make test
/Users/smerla/git/src/github.com/NVIDIA/k8s-nim-operator/bin/controller-gen-v0.15.0 rbac:roleName=manager-role crd webhook paths="./..." output:crd:artifacts:config=config/crd/bases
/Users/smerla/git/src/github.com/NVIDIA/k8s-nim-operator/bin/controller-gen-v0.15.0 object:headerFile="hack/boilerplate.go.txt" paths="./..."
go fmt ./...
go vet ./...
KUBEBUILDER_ASSETS="/Users/smerla/git/src/github.com/NVIDIA/k8s-nim-operator/bin/k8s/1.30.0-darwin-amd64" go test $(go list ./... | grep -v /e2e) -coverprofile cover.out
        github.com/NVIDIA/k8s-nim-operator/api/v1alpha1         coverage: 0.0% of statements
        github.com/NVIDIA/k8s-nim-operator/api/versioned                coverage: 0.0% of statements
        github.com/NVIDIA/k8s-nim-operator/api/versioned/fake           coverage: 0.0% of statements
        github.com/NVIDIA/k8s-nim-operator/api/versioned/scheme         coverage: 0.0% of statements
        github.com/NVIDIA/k8s-nim-operator/api/versioned/typed/v1alpha1/internalversion         coverage: 0.0% of statements
        github.com/NVIDIA/k8s-nim-operator/api/versioned/typed/v1alpha1/internalversion/fake            coverage: 0.0% of statements
        github.com/NVIDIA/k8s-nim-operator/cmd          coverage: 0.0% of statements
        github.com/NVIDIA/k8s-nim-operator/internal/conditions          coverage: 0.0% of statements
?       github.com/NVIDIA/k8s-nim-operator/internal/controller/platform [no test files]
?       github.com/NVIDIA/k8s-nim-operator/internal/render/types        [no test files]
        github.com/NVIDIA/k8s-nim-operator/internal/controller/platform/kserve          coverage: 0.0% of statements
        github.com/NVIDIA/k8s-nim-operator/internal/shared              coverage: 0.0% of statements
        github.com/NVIDIA/k8s-nim-operator/test/utils           coverage: 0.0% of statements
ok      github.com/NVIDIA/k8s-nim-operator/internal/controller  9.283s  coverage: 20.2% of statements
ok      github.com/NVIDIA/k8s-nim-operator/internal/controller/platform/standalone      5.069s  coverage: 31.5% of statements
ok      github.com/NVIDIA/k8s-nim-operator/internal/nimparser   1.829s  coverage: 6.1% of statements
ok      github.com/NVIDIA/k8s-nim-operator/internal/render      4.593s  coverage: 63.2% of statements
ok      github.com/NVIDIA/k8s-nim-operator/internal/utils       2.670s  coverage: 79.8% of statements

@shivamerla shivamerla self-assigned this Aug 2, 2024
@ArangoGutierrez
Add Dependabot
7628117 
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
@ArangoGutierrez
Add GitHub Actions
f63cfe6 
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
@ArangoGutierrez
Add helm linting
840a5ec 
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
@ArangoGutierrez
Copy link
Collaborator

Please rebase

ArangoGutierrez and others added 2 commits August 2, 2024 17:11
@ArangoGutierrez
Fix actions
64808bd 
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
@ArangoGutierrez
Merge pull request #11 from ArangoGutierrez/test-actions
33e8ace 
Test actions
@shivamerla shivamerla closed this Aug 2, 2024
@shivamerla shivamerla reopened this Aug 2, 2024
@shivamerla
Copy link
Collaborator Author

/rebase

ArangoGutierrez and others added 3 commits August 2, 2024 17:45
@ArangoGutierrez
Only add --provenance flag during multiarch builds
e64ed9f 
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
@ArangoGutierrez
Merge pull request #17 from ArangoGutierrez/multiarch
c677f71 
Only add --provenance flag during multiarch builds
@shivamerla
Add clientsets for NIM Operator custom CRDs
6f8e9c1 
Signed-off-by: Shiva Krishna, Merla <[email protected]>
ArangoGutierrez
ArangoGutierrez requested changes Aug 2, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
tools/go.mod Outdated Show resolved Hide resolved
tools/go.mod Outdated Show resolved Hide resolved
@ArangoGutierrez
Copy link
Collaborator 

~/git/src/github.com/NVIDIA/k8s-nim-operator$ make test
/Users/smerla/git/src/github.com/NVIDIA/k8s-nim-operator/bin/controller-gen-v0.15.0 rbac:roleName=manager-role crd webhook paths="./..." output:crd:artifacts:config=config/crd/bases
/Users/smerla/git/src/github.com/NVIDIA/k8s-nim-operator/bin/controller-gen-v0.15.0 object:headerFile="hack/boilerplate.go.txt" paths="./..."
go fmt ./...
go vet ./...
KUBEBUILDER_ASSETS="/Users/smerla/git/src/github.com/NVIDIA/k8s-nim-operator/bin/k8s/1.30.0-darwin-amd64" go test $(go list ./... | grep -v /e2e) -coverprofile cover.out
        github.com/NVIDIA/k8s-nim-operator/api/v1alpha1         coverage: 0.0% of statements
        github.com/NVIDIA/k8s-nim-operator/api/versioned                coverage: 0.0% of statements
        github.com/NVIDIA/k8s-nim-operator/api/versioned/fake           coverage: 0.0% of statements
        github.com/NVIDIA/k8s-nim-operator/api/versioned/scheme         coverage: 0.0% of statements
        github.com/NVIDIA/k8s-nim-operator/api/versioned/typed/v1alpha1/internalversion         coverage: 0.0% of statements
        github.com/NVIDIA/k8s-nim-operator/api/versioned/typed/v1alpha1/internalversion/fake            coverage: 0.0% of statements
        github.com/NVIDIA/k8s-nim-operator/cmd          coverage: 0.0% of statements
        github.com/NVIDIA/k8s-nim-operator/internal/conditions          coverage: 0.0% of statements
?       github.com/NVIDIA/k8s-nim-operator/internal/controller/platform [no test files]
?       github.com/NVIDIA/k8s-nim-operator/internal/render/types        [no test files]
        github.com/NVIDIA/k8s-nim-operator/internal/controller/platform/kserve          coverage: 0.0% of statements
        github.com/NVIDIA/k8s-nim-operator/internal/shared              coverage: 0.0% of statements
        github.com/NVIDIA/k8s-nim-operator/test/utils           coverage: 0.0% of statements
ok      github.com/NVIDIA/k8s-nim-operator/internal/controller  9.283s  coverage: 20.2% of statements
ok      github.com/NVIDIA/k8s-nim-operator/internal/controller/platform/standalone      5.069s  coverage: 31.5% of statements
ok      github.com/NVIDIA/k8s-nim-operator/internal/nimparser   1.829s  coverage: 6.1% of statements
ok      github.com/NVIDIA/k8s-nim-operator/internal/render      4.593s  coverage: 63.2% of statements
ok      github.com/NVIDIA/k8s-nim-operator/internal/utils       2.670s  coverage: 79.8% of statements

https://github.com/NVIDIA/k8s-nim-operator/actions/runs/10219425499/job/28277659091?pr=9

ArangoGutierrez
ArangoGutierrez reviewed Aug 5, 2024
View reviewed changes
Makefile Outdated
@@ -82,6 +87,19 @@ manifests: controller-gen ## Generate WebhookConfiguration, ClusterRole and Cust
generate: controller-gen ## Generate code containing DeepCopy, DeepCopyInto, and DeepCopyObject method implementations.
$(CONTROLLER_GEN) object:headerFile="hack/boilerplate.go.txt" paths="./..."

.PHONY: generate-clientset
generate-clientset: install-tools
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have a dockerized way of doing this. not a blocker, but sometimes is better to run this tools in a Linux controlled env

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should work in the container too, it just installs all binaries under GOBIN.

@shivamerla shivamerla closed this Aug 5, 2024
auto-merge was automatically disabled August 5, 2024 21:12

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez ArangoGutierrez requested changes

@visheshtanksale visheshtanksale Awaiting requested review from visheshtanksale visheshtanksale is a code owner

Assignees

@shivamerla shivamerla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shivamerla @ArangoGutierrez @visheshtanksale