Misc spec updates #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
shivamerla
commented
Aug 6, 2024
shivamerla
commented
- Update NGC modelPuller to be immutable as model profiles cached are tied to each NIM container
- Change hpaSpec to hpa.
- Make resources optional for NIMCache
- Update CRDs across all folders
shivamerla
requested review from
ArangoGutierrez and
visheshtanksale
as code owners
ArangoGutierrez
previously approved these changes
Aug 6, 2024
1. Update NGC modelPuller to be immutable as model profiles cached are tied to each NIM container 2. Change hpaSpec to hpa. 3. Make resources optional for NIMCache 4. Update CRDs across all folders Signed-off-by: Shiva Krishna, Merla <[email protected]>
shivamerla
dismissed stale reviews from visheshtanksale and ArangoGutierrez
via
7229b32
shivamerla
force-pushed
the
update_misc_spec
branch
from
1bbb68a to
7229b32
Compare
ArangoGutierrez
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.