Make unittest compilation faster #2402
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skylion007
reviewed
Jun 15, 2025
bin2hex.cmake
Outdated
| FILE(READ "${FILENAME}" RAW_CONTENT) | ||
|
|
||
| set(RAW_DELIM_END "abc1ae6e1e82e3de") | ||
| set(RESULT "static char const ${VARIABLE_NAME}[] = R\"${RAW_DELIM_END}(\n${RAW_CONTENT})${RAW_DELIM_END}\";\n") |
There was a problem hiding this comment.
Shouldn't these constexpr static char const...
There was a problem hiding this comment.
Thanks. Just doing my best to preserve compatibility with the previous code.
There was a problem hiding this comment.
Thanks. Just doing my best to preserve compatibility with the previous code.
There was a problem hiding this comment.
@Skylion007 thanks, added constexpr
d-k-b
reviewed
Jun 16, 2025
|
This PR has been labeled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FILE_TO_C_STRING creates gigantic files consisting mainly of sequences char(0xNN). Just including such a file takes a long time (e.g. 27 seconds for build/test/unit/nvrts/nvrtc/cute/arch/mma_sm90_gmma_sparse_ext.hpp).
This PR generates files as raw delimited C++ strings. This reduces the cost of compilation by roughly 10x. There are over 500 such files.