Conversation
miscco
approved these changes
Mar 27, 2025
miscco
reviewed
Mar 27, 2025
Contributor
miscco
left a comment
There was a problem hiding this comment.
This suggests a lack of testing, can you add a test that verifies this works correctly?
Contributor
Agreed. When fixing a bug, it's best to first add a test exposing the bug and then adding the fix. This way, we can avoid regressions. |
Contributor
🟩 CI finished in 17h 15m: Pass: 100%/162 | Total: 3d 10h | Avg: 30m 39s | Max: 1h 21m | Hits: 66%/254022
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | libcu++ |
| CUB | |
| Thrust | |
| CUDA Experimental | |
| stdpar | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
| +/- | CUDA Experimental |
| +/- | stdpar |
| +/- | python |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
🏃 Runner counts (total jobs: 162)
| # | Runner |
|---|---|
| 113 | linux-amd64-cpu16 |
| 15 | windows-amd64-cpu16 |
| 12 | linux-arm64-cpu16 |
| 8 | linux-amd64-gpu-rtx2080-latest-1 |
| 6 | linux-amd64-gpu-rtxa6000-latest-1 |
| 5 | linux-amd64-gpu-h100-latest-1 |
| 3 | linux-amd64-gpu-rtx4090-latest-1 |
andralex
pushed a commit
to andralex/cccl
that referenced
this pull request
Apr 1, 2025
davebayer
pushed a commit
to davebayer/cccl
that referenced
this pull request
Apr 7, 2025
caugonnet
added a commit
that referenced
this pull request
Apr 15, 2025
* clang-format * remove unnecessary headers * Remove few remaining qualifiers _CCCL_NODISCARD This fixes the build, after the macro definition was removed in #4265 * fix headers * Cleanup libcu++ `force_include.h` test file (#4262) * there are no more tests in this header * Simplify and reduce data copying in algorithm.cuh * Much less tupling and untupling * A few additional simplifications and a few eliminations of copies * Fix ratio plot (#4099) * Fix ratio plot * [pre-commit.ci] auto code formatting --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Bernhard Manfred Gruber <bernhardmgruber@gmail.com> * Drop `_CCCL_NORETURN` (#4268) Co-authored-by: Michael Schellenberger Costa <miscco@nvidia.com> * fix clang portability issue in `__rcvr_with_env_t` and remove dead code (#4277) * change version check in `type_list.h` so that *NO* clang-19.X compilers try to use pack indexing (#4278) * fix shfl check (#4282) * Add necessary headers * tweak the cccl compiler version check macros to better agree with intuition (#4279) * tweak the cccl compiler version check macros to better agree with intuition prior to this commit, a compiler check such as: ```c++ ``` would fail if the compiler was actually v19.1. that is because 19.1 is greater than 19. what the author of this code probably intended was to check only the compiler's major version number, in which case the check would have succeed. this commit changes the behavior of the following macros when only a major version number is specified: * `_CCCL_COMPILER` * `_CCCL_CUDA_COMPILER` * `_CCCL_CUDACC_BELOW` * `_CCCL_CUDACC_AT_LEAST` * guard `_CCCL_COMPILER(FOO)` with an extra set of parens * Implement `ranges::single_view` (#4255) * Implement fp overflow handlers (#4261) * Implement fp overflow handlers * I hate nvfp types * use `[[nodiscard]]` --------- Co-authored-by: Michael Schellenberger Costa <miscco@nvidia.com> * Fix CI failure * Drop `_LIBCUDACXX_HAS_NO_UNICODE_CHARS` (#4295) * [Version] Update main to v3.1.0 (#4175) * Bump main to 3.1.0. * Update ci/update_version.sh to edit the docs VERSION.md file * Rerun ci/version_update.sh --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Wesley Maxey <wesley.maxey@gmail.com> * WIP: Refactor allocators * Make metadata direct member instead of pointer * Add cached_block_allocator_fifo from PR #2674 * use _CCCL_ASSERT instead of assert * add missing ctors --------- Co-authored-by: Cedric Augonnet <caugonnet@nvidia.com> Co-authored-by: Oleksandr Pavlyk <21087696+oleksandr-pavlyk@users.noreply.github.com> Co-authored-by: David Bayer <48736217+davebayer@users.noreply.github.com> Co-authored-by: Georgii Evtushenko <evtushenko.georgy@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Bernhard Manfred Gruber <bernhardmgruber@gmail.com> Co-authored-by: Michael Schellenberger Costa <miscco@nvidia.com> Co-authored-by: Eric Niebler <eniebler@nvidia.com> Co-authored-by: Federico Busato <50413820+fbusato@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Wesley Maxey <wesley.maxey@gmail.com> Co-authored-by: Cédric Augonnet <158148890+caugonnet@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.