Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency graph #659

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

polinabinder1
Copy link
Collaborator

No description provided.

Signed-off-by: Polina Binder <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.75%. Comparing base (a2fd916) to head (9ed7b1e).
Report is 17 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #659      +/-   ##
==========================================
+ Coverage   86.59%   86.75%   +0.15%     
==========================================
  Files         116      118       +2     
  Lines        6937     7058     +121     
==========================================
+ Hits         6007     6123     +116     
- Misses        930      935       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

return pyproject_files


def parse_dependencies(pyproject_path):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we could also parse tach.toml and possibly warn if the dependency graphs are different? The tach check actually enforces this separation during CI, so it's probably more accurate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants