Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to SCDL and documentation #643

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Changes to SCDL and documentation #643

wants to merge 6 commits into from

Conversation

polinabinder1
Copy link
Collaborator

No description provided.

@polinabinder1
[skip ci]
17a56de 
Signed-off-by: Polina Binder <[email protected]>
@polinabinder1
[skip-ci]
ee37cf9 
Signed-off-by: Polina Binder <[email protected]>
@polinabinder1
README add
41317c3 
Signed-off-by: Polina Binder <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.72%. Comparing base (939bc72) to head (161f8b4).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../src/bionemo/scdl/io/single_cell_memmap_dataset.py 57.14% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #643      +/-   ##
==========================================
- Coverage   86.75%   86.72%   -0.03%     
==========================================
  Files         118      118              
  Lines        7058     7065       +7     
==========================================
+ Hits         6123     6127       +4     
- Misses        935      938       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@polinabinder1 polinabinder1 marked this pull request as ready for review January 24, 2025 20:27
@polinabinder1 polinabinder1 marked this pull request as draft January 24, 2025 20:28
@polinabinder1 polinabinder1 marked this pull request as ready for review January 24, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstjohn jstjohn Awaiting requested review from jstjohn jstjohn is a code owner

@malcolmgreaves malcolmgreaves Awaiting requested review from malcolmgreaves malcolmgreaves is a code owner

@skothenhill-nv skothenhill-nv Awaiting requested review from skothenhill-nv skothenhill-nv is a code owner

@dorotat-nv dorotat-nv Awaiting requested review from dorotat-nv dorotat-nv is a code owner

@pstjohn pstjohn Awaiting requested review from pstjohn pstjohn is a code owner

@trvachov trvachov Awaiting requested review from trvachov trvachov is a code owner

@jwilber jwilber Awaiting requested review from jwilber jwilber is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@polinabinder1 @codecov-commenter