Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for marking and skipping slow tests, temporarily mark pydantic tests as slow #589

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

pstjohn
Copy link
Collaborator

@pstjohn pstjohn commented Jan 10, 2025

Description

These pydantic CLI tests are currently taking an inordinate amount of time to run. This PR adds support for using pytest.mark.slow to flag tests not to run during pre-merge testing, but will still be run during nightly tests.

Also adds some cleanup to the azure runner test suite to remove the docker container from the GPU runner since these are not ephemeral workers, and updates the cache mounting location for the container job to re-use downloads.

See https://nvidia.slack.com/archives/C074Z808N05/p1736460988702949
https://jirasw.nvidia.com/browse/BIONEMO-553

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactor
  • Documentation update
  • Other (please describe):

CI Pipeline Configuration

Configure CI behavior by checking relevant boxes below. This will automatically apply labels.

Note

By default, the notebooks validation tests are skipped unless explicitly enabled.

Usage

TODO: Add code snippet

Pre-submit Checklist

  • I have tested these changes locally
  • I have updated the documentation accordingly
  • I have added/updated tests as needed
  • All existing tests pass successfully

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.78%. Comparing base (c691df2) to head (be176e9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #589      +/-   ##
==========================================
+ Coverage   87.73%   88.78%   +1.04%     
==========================================
  Files          89       81       -8     
  Lines        5758     5027     -731     
==========================================
- Hits         5052     4463     -589     
+ Misses        706      564     -142     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pstjohn pstjohn changed the title Temporarily disable pydantic tests Add support for marking slow tests, temporarily mark pydantic tests as slow Jan 10, 2025
@pstjohn pstjohn changed the title Add support for marking slow tests, temporarily mark pydantic tests as slow Add support for marking and skipping slow tests, temporarily mark pydantic tests as slow Jan 10, 2025
pstjohn and others added 4 commits January 10, 2025 16:08
Signed-off-by: Peter St. John <[email protected]>
Signed-off-by: Peter St. John <[email protected]>
Signed-off-by: Peter St. John <[email protected]>
Signed-off-by: Peter St. John <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants