Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable incremental CMake build #684

Merged
merged 7 commits into from
Mar 4, 2024

Conversation

jinzex
Copy link
Contributor

@jinzex jinzex commented Feb 26, 2024

Currently, the CMakeExtension builds are saved in a temporary directory, which is cleaned up after the build finishes.

Saving them to a local build directory allows for incremental CMake builds that only recompile the source files that have changed.

@jinzex jinzex force-pushed the enable_incremental_cmake_build branch from 60875c6 to 8f2c813 Compare February 26, 2024 17:38
@timmoon10 timmoon10 self-requested a review February 27, 2024 17:24
@timmoon10 timmoon10 added the build Build system label Feb 27, 2024
Copy link
Collaborator

@timmoon10 timmoon10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good idea. My suggestions are stylistic.

setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
@timmoon10 timmoon10 self-requested a review February 27, 2024 17:32
jinzex and others added 4 commits February 27, 2024 12:27
Co-authored-by: Tim Moon <[email protected]>
Signed-off-by: Jinze Xue <[email protected]>
Co-authored-by: Tim Moon <[email protected]>
Signed-off-by: Jinze Xue <[email protected]>
Signed-off-by: Jinze Xue <[email protected]>
@ksivaman
Copy link
Member

/te-ci

Copy link
Member

@ksivaman ksivaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timmoon10
Copy link
Collaborator

/te-ci

@timmoon10
Copy link
Collaborator

/te-ci jax

@ksivaman
Copy link
Member

ksivaman commented Mar 4, 2024

/te-ci pytorch

@ksivaman ksivaman merged commit 509ab0b into NVIDIA:main Mar 4, 2024
9 of 10 checks passed
@jinzex jinzex deleted the enable_incremental_cmake_build branch March 5, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants