[JAX] Support various implementations of RoPE. #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/te-ci jax |
denera
approved these changes
Feb 5, 2024
|
@nouiz Do we need JET CI for this? |
|
I think so. We discovered this issue as the current Rope wasn't used by JET CI if I understood correctly. So that would be the first CI run that use it. |
mingxu1067
changed the title
|
/te-ci jax |
|
Hi @mingxu1067, I found this PR cause functional regression on the LLaMA model. We can discuss offline in the next week. |
mingxu1067
force-pushed
the
mingh/support_variant_rope_impl
branch
from
f61518e to
1c18a40
Compare
|
/te-ci jax |
mingxu1067
force-pushed
the
mingh/support_variant_rope_impl
branch
from
1c18a40 to
a9bb39e
Compare
…tation bug Signed-off-by: Ming Huang <[email protected]>
mingxu1067
force-pushed
the
mingh/support_variant_rope_impl
branch
from
a9bb39e to
375209b
Compare
|
/te-ci jax |
|
@denera @nouiz @zlsh80826 |
|
@mingxu1067 LGTM! Thanks for seeing this through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alternateis to pair indexiwithi + d/2,
dis the hidden dimension. 'consecutive' pairs indexiwithi + 1.