[Common] Optimize fused RoPE kernel performance #2508
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Optimizations:
freqsto shared memory, because each entry offreqsis only used by one thread and not shared. This avoids thread sync and shared memory bank conflict.freqs.Performance
Tested on GB200:
1.2-1.4x speedup for fwd and 1.5-1.6x speedup for bwd.
Shape
[4096, 1, 128, 128]insbhd.Shape
[512, 32, 24, 128]insbhd.Type of change
Changes
Please list the changes introduced in this PR:
Checklist: