-
Notifications
You must be signed in to change notification settings - Fork 583
[PyTorch] Documentation for op fuser API #2447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Tim Moon <[email protected]>
Signed-off-by: Tim Moon <[email protected]>
Greptile SummaryThis PR adds comprehensive documentation for the operation fuser API, including a detailed usage guide with examples covering basic usage, quantization, and branching operations. The documentation also includes diagrams illustrating fusion patterns and implementation details. The PR also improves docstring formatting across the ops module:
Key additions:
Minor issue found:
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant Documentation as docs/examples/op_fuser/op_fuser.rst
participant API_Docs as docs/api/pytorch.rst
participant Ops_Module as transformer_engine.pytorch.ops
participant Docstrings as Python Docstrings
User->>Documentation: Read op fuser guide
Documentation->>Documentation: Learn basic usage
Documentation->>Documentation: Learn quantization patterns
Documentation->>Documentation: Learn branching operations
User->>API_Docs: Reference API documentation
API_Docs->>Ops_Module: Autogenerate from docstrings
Ops_Module->>Docstrings: Source documentation
Note over Documentation,Docstrings: PR improves formatting<br/>across all documentation layers
Docstrings->>Docstrings: Fix RST syntax (double backticks)
Docstrings->>Docstrings: Fix parameter defaults
Docstrings->>Docstrings: Fix hyperlink spacing
API_Docs->>User: Provide clean API reference
Documentation->>User: Provide usage examples
|
Signed-off-by: Tim Moon <[email protected]>
Review suggestion from @greptile-apps Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Signed-off-by: Tim Moon <[email protected]>
|
/te-ci core pytorch |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Signed-off-by: Tim Moon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
transformer_engine/pytorch/ops/basic/activation.py, line 387 (link)syntax: Extra space before period.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
19 files reviewed, 1 comment
Description
This PR adds a basic usage guide for the op fuser and includes it in the autogenerated API docs.
It is ready as-is, but if reviews take a while I may expand it with a guide on creating custom fused ops.
Type of change
Changes
Checklist: