Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[common/PyTorch] Add cuDNN SWA (left, 0) + padding + bottom right causal #1378

Merged
merged 10 commits into from
Dec 20, 2024

Conversation

cyanguwa
Copy link
Collaborator

@cyanguwa cyanguwa commented Dec 17, 2024

Description

This PR adds SWA (left, 0) support to the FusedAttention backend for {bshd, sbhd, thd} formats and {no_mask, causal, causal_bottom_right, padding, padding_causal, padding_causal_bottom_right} masks.

Previously, the support was only for SWA (left, 0) with {bshd, sbhd} formats, and {no_mask, causal} mask.

This PR requires cudnn-frontend 1.9.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refractor

Changes

Please list the changes introduced in this PR:

  • Add cuDNN SWA (left, 0) + padding + bottom right causal

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@cyanguwa cyanguwa requested a review from zlsh80826 December 17, 2024 10:24
@cyanguwa
Copy link
Collaborator Author

cyanguwa commented Dec 18, 2024

This PR currently passes all tests with cudnn-frontend 1.9 develop branch. Will run full TE CI when 1.9 is released.

@cyanguwa
Copy link
Collaborator Author

/te-ci pytorch

@cyanguwa
Copy link
Collaborator Author

/te-ci jax

@cyanguwa
Copy link
Collaborator Author

/te-ci paddle

Signed-off-by: Charlene Yang <[email protected]>
@cyanguwa
Copy link
Collaborator Author

/te-ci jax

@cyanguwa cyanguwa merged commit 838345e into NVIDIA:main Dec 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants