Add THD format support for Context Parallel #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunlunl
force-pushed
the
add_thd_for_cp
branch
2 times, most recently
from
514b9b6 to
afd7fe1
Compare
|
Add some custom CUDA kernels to replace the pytorch native op, to make the THD and BSHD have the same performance when using context parallel. |
xrennvidia
reviewed
Apr 19, 2024
xrennvidia
reviewed
Apr 19, 2024
kunlunl
force-pushed
the
add_thd_for_cp
branch
2 times, most recently
from
dea2a00 to
43add29
Compare
kunlunl
force-pushed
the
add_thd_for_cp
branch
2 times, most recently
from
7aea011 to
8ced458
Compare
|
/te-ci pytorch |
|
@kunlunl thanks for the PR. Could you fix the DCO and lint errors please? Instructions are in the Details link. Thanks. |
cyanguwa
reviewed
May 3, 2024
|
@kunlunl could you also please update the pytest version to 7.2 in |
kunlunl
force-pushed
the
add_thd_for_cp
branch
2 times, most recently
from
044b028 to
80686b7
Compare
Signed-off-by: kunlunl <[email protected]>
@cyanguwa Both are done. |
|
/te-ci pytorch |
cyanguwa
approved these changes
May 13, 2024
3 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make Context Parallel support THD format.
Currently only the Flash Attention Backend is supported as Fused Attention doesn't support THD format.