[https://nvbugs/5759698][fix] unwaive test_base_worker

[Superjomn]

Summary by CodeRabbit

• Tests
  • Enhanced test isolation to improve test reliability and coverage
  • Enabled a previously disabled test to validate additional functionality

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

• PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

• PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

• Test cases are provided for new code paths (see test instructions)

• Any new dependencies have been scanned for license and vulnerabilities

• CODEOWNERS updated if ownership changes

• Documentation updated as needed

• Update tava architecture diagram if there is a significant design change in PR.

• The reviewers assigned automatically/manually are appropriate for the PR.

• Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

[Superjomn]

/bot run --stage-list "A100X-PyTorch-1"

[Superjomn]

/bot run --stage-list "A100X-PyTorch-1"

[coderabbitai]

📝 Walkthrough

Walkthrough

Test configuration updates for unittest/executor/test_base_worker.py: an ISOLATION qualifier is added to the test entry in the test database configuration, and a corresponding SKIP waiver is removed from the waives list.

Changes

Cohort / File(s)	Change Summary
Test Configuration and Waivers tests/integration/test_lists/test-db/l0_a100.yml, tests/integration/test_lists/waives.txt	Added ISOLATION qualifier to unittest/executor/test_base_worker.py entry in test database configuration; removed SKIP waiver entry for unittest/executor/test_base_worker.py::TestWorkerBase from waivers list

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description only contains the template with no actual content filled in—the Description, Test Coverage sections are empty, and the checklist is unchecked.	Complete the PR description by explaining why test_base_worker was waived, why the waive is now being removed, and confirm what test coverage validates this change.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title '[https://nvbugs/5759698][fix] unwaive test_base_worker' follows the template and directly describes the main change: removing a waive from the test_base_worker test.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e7882d5 and 45dbb3c.

📒 Files selected for processing (2)

• tests/integration/test_lists/test-db/l0_a100.yml
• tests/integration/test_lists/waives.txt

💤 Files with no reviewable changes (1)

• tests/integration/test_lists/waives.txt

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-09-09T13:33:32.247Z

Learnt from: EmmaQiaoCh
Repo: NVIDIA/TensorRT-LLM PR: 7497
File: tests/integration/defs/test_list_parser.py:0-0
Timestamp: 2025-09-09T13:33:32.247Z
Learning: The ISOLATE marker in test_list_parser.py is used for test list parsing and Jenkins pipeline logic, not for creating pytest markers. It allows the parser to recognize ISOLATE markers in test list files, which the Jenkins pipeline then uses to separate tests that need isolation, but no pytest.mark.isolate marker is created.

Applied to files:

• tests/integration/test_lists/test-db/l0_a100.yml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Pre-commit Check

🔇 Additional comments (1)

tests/integration/test_lists/test-db/l0_a100.yml (1)

25-25: LGTM! Appropriate use of ISOLATION marker.

Re-enabling the test with ISOLATION is consistent with the existing pattern (e.g., line 20 for test_mpi_session.py). Based on the retrieved learnings, this marker ensures the Jenkins pipeline runs this test separately, which should address the underlying issue that caused the test to be waived.

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[tensorrt-cicd]

PR_Github #31958 [ run ] triggered by Bot. Commit: 45dbb3c

[tensorrt-cicd]

PR_Github #31959 [ run ] triggered by Bot. Commit: 45dbb3c

[tensorrt-cicd]

PR_Github #31958 [ run ] completed with state ABORTED. Commit: 45dbb3c

[tensorrt-cicd]

PR_Github #31959 [ run ] completed with state FAILURE. Commit: 45dbb3c
/LLM/main/L0_MergeRequest_PR pipeline #24756 (Partly Tested) completed with status: 'FAILURE'

⚠️ Action Required:

• Please check the failed tests and fix your PR
• If you cannot view the failures, ask the CI triggerer to share details
• Once fixed, request an NVIDIA team member to trigger CI again

[Superjomn]

/bot run

[Superjomn]

/bot run --stage-list "A100X-PyTorch-1"

[tensorrt-cicd]

PR_Github #32039 [ run ] triggered by Bot. Commit: 433b761

[tensorrt-cicd]

PR_Github #32041 [ run ] triggered by Bot. Commit: 433b761

[tensorrt-cicd]

PR_Github #32039 [ run ] completed with state ABORTED. Commit: 433b761

[tensorrt-cicd]

PR_Github #32041 [ run ] completed with state SUCCESS. Commit: 433b761
/LLM/main/L0_MergeRequest_PR pipeline #24832 (Partly Tested) completed with status: 'SUCCESS'