[https://nvbugs/5794313][chore] unwaive tests. #10660

yuxianq · 2026-01-14T07:49:58Z

Description

This bug has been fixed by #10547, unwaive tests.

Test Coverage

PR Checklist

Please review the following before submitting your PR:

PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Summary by CodeRabbit

Tests
- Re-enabled a previously skipped integration test to improve test coverage.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Signed-off-by: Yuxian Qiu <[email protected]>

coderabbitai · 2026-01-14T07:51:56Z

📝 Walkthrough

Walkthrough

A single line was removed from the test waives file, removing a skip annotation for a previously skipped test entry, thereby re-enabling the test.

Changes

Cohort / File(s)	Summary
Test Waives Configuration `tests/integration/test_lists/waives.txt`	Removed one SKIP annotation entry, re-enabling a previously skipped test

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

[https://nvbugs/5701425][chore] Unwaive tests. #10269: Also removes SKIP entries from tests/integration/test_lists/waives.txt to unskip tests
[https://nvbugs/5740359][chore] Unwaive tests. #10260: Modifies the same waives.txt file to change SKIP/waive entries for related tests

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly and specifically describes the main change: removing test skip annotations (unwaiving tests) to address a fixed bug.
Description check	✅ Passed	The description provides essential context (references the bug fix PR `#10547`) but lacks detail on which specific tests are being unwaived or why they're safe to run.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c4da4fd and 6189380.

📒 Files selected for processing (1)

tests/integration/test_lists/waives.txt

💤 Files with no reviewable changes (1)

tests/integration/test_lists/waives.txt

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Pre-commit Check

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

yuxianq · 2026-01-14T07:53:30Z

/bot run --disable-fail-fast --extra-stage "RTXPro6000D-4_GPUs-PyTorch-Post-Merge-1, RTXPro6000D-4_GPUs-PyTorch-Post-Merge-2"

tensorrt-cicd · 2026-01-14T07:58:53Z

PR_Github #31924 [ run ] triggered by Bot. Commit: 6189380

tensorrt-cicd · 2026-01-14T08:22:19Z

PR_Github #31924 [ run ] completed with state FAILURE. Commit: 6189380
/LLM/main/L0_MergeRequest_PR pipeline #24726 completed with status: 'FAILURE'

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

yuxianq · 2026-01-14T10:24:23Z

/bot run --disable-fail-fast --extra-stage "RTXPro6000D-4_GPUs-PyTorch-Post-Merge-1, RTXPro6000D-4_GPUs-PyTorch-Post-Merge-2"

tensorrt-cicd · 2026-01-14T10:29:44Z

PR_Github #31961 [ run ] triggered by Bot. Commit: d5ed7d7

tensorrt-cicd · 2026-01-14T14:27:53Z

PR_Github #31961 [ run ] completed with state SUCCESS. Commit: d5ed7d7
/LLM/main/L0_MergeRequest_PR pipeline #24759 completed with status: 'FAILURE'

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

yuxianq · 2026-01-15T08:04:37Z

/bot run --disable-fail-fast --extra-stage "RTXPro6000D-4_GPUs-PyTorch-Post-Merge-1, RTXPro6000D-4_GPUs-PyTorch-Post-Merge-2"

tensorrt-cicd · 2026-01-15T08:10:09Z

PR_Github #32098 [ run ] triggered by Bot. Commit: d5ed7d7

unwaive tests.

6189380

Signed-off-by: Yuxian Qiu <[email protected]>

yuxianq requested review from mikeiovine and ziyixiong-nv January 14, 2026 07:49

ziyixiong-nv approved these changes Jan 14, 2026

View reviewed changes

Merge branch 'main' into unwaive-test-5794313

d5ed7d7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[https://nvbugs/5794313][chore] unwaive tests. #10660

[https://nvbugs/5794313][chore] unwaive tests. #10660

yuxianq commented Jan 14, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jan 14, 2026

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Uh oh!

yuxianq commented Jan 14, 2026

Uh oh!

tensorrt-cicd commented Jan 14, 2026

Uh oh!

tensorrt-cicd commented Jan 14, 2026

Uh oh!

yuxianq commented Jan 14, 2026

Uh oh!

tensorrt-cicd commented Jan 14, 2026

Uh oh!

tensorrt-cicd commented Jan 14, 2026

Uh oh!

yuxianq commented Jan 15, 2026

Uh oh!

tensorrt-cicd commented Jan 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[https://nvbugs/5794313][chore] unwaive tests. #10660

Are you sure you want to change the base?

[https://nvbugs/5794313][chore] unwaive tests. #10660

Conversation

yuxianq commented Jan 14, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Test Coverage

PR Checklist

GitHub Bot Help

kill

skip

reuse-pipeline

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jan 14, 2026

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Uh oh!

yuxianq commented Jan 14, 2026

Uh oh!

tensorrt-cicd commented Jan 14, 2026

Uh oh!

tensorrt-cicd commented Jan 14, 2026

Uh oh!

yuxianq commented Jan 14, 2026

Uh oh!

tensorrt-cicd commented Jan 14, 2026

Uh oh!

tensorrt-cicd commented Jan 14, 2026

Uh oh!

yuxianq commented Jan 15, 2026

Uh oh!

tensorrt-cicd commented Jan 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yuxianq commented Jan 14, 2026 •

edited by coderabbitai bot

Loading