Skip to content

Conversation

@ruodil
Copy link
Collaborator

@ruodil ruodil commented Jan 14, 2026

Summary by CodeRabbit

  • Tests
    • Added support for tracking two new performance metrics in the benchmarking system: per-user output throughput and per-GPU output throughput, enabling enhanced performance monitoring and analysis.

✏️ Tip: You can customize this high-level summary in your review settings.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 14, 2026

📝 Walkthrough

Walkthrough

Adds two new performance metrics (PER_USER_OUTPUT_THROUGHPUT and PER_GPU_OUTPUT_THROUGHPUT) to the performance testing framework. Changes include new enum members in the metric type definition and corresponding regex patterns for parsing these metrics from benchmark output.

Changes

Cohort / File(s) Summary
Performance Metric Type Additions
tests/integration/defs/perf/utils.py, tests/integration/defs/perf/test_perf.py
Introduces two new enum members (PER_USER_OUTPUT_THROUGHPUT, PER_GPU_OUTPUT_THROUGHPUT) and their corresponding regex patterns for parsing Per User and Per GPU output throughput metrics from benchmark results.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description lacks all critical required content. The Description, Test Coverage, and PR Checklist sections are completely empty or only contain template placeholders. Fill in the Description section explaining what metrics are being added and why. Document which tests validate these changes in the Test Coverage section. Complete the PR Checklist items as applicable.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly indicates the main change: adding per-user and per-GPU output metrics to CSV file storage in the test suite.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ruodil
Copy link
Collaborator Author

ruodil commented Jan 14, 2026

/bot skip --comment"only add perf metrics"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31925 Bot args parsing error: usage: /bot skip --comment COMMENT
/bot skip: error: the following arguments are required: --comment

@ruodil
Copy link
Collaborator Author

ruodil commented Jan 15, 2026

/bot skip --comment "only add perf metrics"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32050 [ skip ] triggered by Bot. Commit: 58e3617

@ruodil ruodil enabled auto-merge (squash) January 15, 2026 03:06
@tensorrt-cicd
Copy link
Collaborator

PR_Github #32050 [ skip ] completed with state SUCCESS. Commit: 58e3617
Skipping testing for commit 58e3617

@ruodil
Copy link
Collaborator Author

ruodil commented Jan 15, 2026

/bot skip --comment "only add perf metrics"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32071 [ skip ] triggered by Bot. Commit: 7a170c5

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32071 [ skip ] completed with state SUCCESS. Commit: 7a170c5
Skipping testing for commit 7a170c5

@ruodil ruodil merged commit 22240e4 into NVIDIA:main Jan 15, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants