Connection test to service should retry on 429 and 503 #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdewanNvidia
temporarily deployed
to
internal-ci
GitHub Actions
Inactive
RyaliNvidia
reviewed
Jan 9, 2026
| url_config.url, | ||
| status_code, | ||
| ) | ||
| return None |
Contributor
There was a problem hiding this comment.
How is the behavior different between this and failure_status_codes since they both return None. How do we differentiate between the two to retry with this one but not with the one below?
ecolternv
reviewed
Jan 9, 2026
| retriable_status_codes: List[int] = pydantic.Field( | ||
| default=[429, 503], description='Status codes that should trigger retry') | ||
| failure_status_codes: List[int] = pydantic.Field( | ||
| default=[500, 501, 502, 504, 505, 506, 507, 508, 510, 511], |
Contributor
There was a problem hiding this comment.
Seems kind of odd that by default this is full of 500 status codes, but down below we have
if status_code in url_config.failure_status_codes or status_code >= 500:
This might as well default to an empty list if we always check all 500 status codes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Connection test to service should retry on 429 and 503
Issue - None
Checklist