-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for bumping pyt to 25.01 #12165
Fixes for bumping pyt to 25.01 #12165
Conversation
Signed-off-by: Maanu Grover <[email protected]>
Signed-off-by: Maanu Grover <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you.
@maanug-nv thanks for this. would you please fix the lint error and also run the one or more tests that you were aiming to fix on this branch? No need to run them all. Then we can merge into Oliver's branch. |
Triggered with 'L0_Unit_Tests_GPU_Lightning': https://github.com/NVIDIA/NeMo/actions/runs/13321343572
|
Signed-off-by: Alexandros Koumparoulis <[email protected]>
f0d4421
to
acf4e1f
Compare
Signed-off-by: Alexandros Koumparoulis <[email protected]>
9a3f1fa
to
547e106
Compare
Signed-off-by: Alexandros Koumparoulis <[email protected]>
eba37a6
to
be0ad0c
Compare
Signed-off-by: Alexandros Koumparoulis <[email protected]>
0ac0127
to
cb3ad67
Compare
Signed-off-by: akoumpa <[email protected]>
Removed the unused import, and triggered same test on CI https://github.com/NVIDIA/NeMo/actions/runs/13323641272 |
Reran after merging in base branch: https://github.com/NVIDIA/NeMo/actions/runs/13325113240 |
b7253e9
into
ko3n1g/build/bump-pyt-25.01
Important
The
Update branch
button must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use this
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information