Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for bumping pyt to 25.01 #12165

Merged
merged 8 commits into from
Feb 14, 2025

Conversation

maanug-nv
Copy link
Collaborator

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@maanug-nv maanug-nv requested review from ko3n1g and akoumpa February 13, 2025 02:24
@github-actions github-actions bot added the core Changes to NeMo Core label Feb 13, 2025
Copy link
Member

@akoumpa akoumpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you.

@akoumpa akoumpa added r2.2.0 and removed r2.2.0 labels Feb 13, 2025
@chtruong814
Copy link
Collaborator

@maanug-nv thanks for this. would you please fix the lint error and also run the one or more tests that you were aiming to fix on this branch? No need to run them all. Then we can merge into Oliver's branch.

@maanug-nv maanug-nv self-assigned this Feb 13, 2025
@maanug-nv
Copy link
Collaborator Author

maanug-nv commented Feb 13, 2025

Triggered with 'L0_Unit_Tests_GPU_Lightning': https://github.com/NVIDIA/NeMo/actions/runs/13321343572

test_state_restoration.py::test_optim_state_restoration and test_nemo_resume_from_ckpt.py::TestCkptStateRestoration::test_resume_optim_state should pass.

Signed-off-by: Alexandros Koumparoulis <[email protected]>
@akoumpa akoumpa force-pushed the maanug/bump-pyt-fixes-2 branch from f0d4421 to acf4e1f Compare February 14, 2025 06:01
Signed-off-by: Alexandros Koumparoulis <[email protected]>
@akoumpa akoumpa force-pushed the maanug/bump-pyt-fixes-2 branch from 9a3f1fa to 547e106 Compare February 14, 2025 06:05
Signed-off-by: Alexandros Koumparoulis <[email protected]>
@akoumpa akoumpa force-pushed the maanug/bump-pyt-fixes-2 branch from eba37a6 to be0ad0c Compare February 14, 2025 06:08
Signed-off-by: Alexandros Koumparoulis <[email protected]>
@akoumpa akoumpa force-pushed the maanug/bump-pyt-fixes-2 branch from 0ac0127 to cb3ad67 Compare February 14, 2025 06:11
@akoumpa
Copy link
Member

akoumpa commented Feb 14, 2025

Removed the unused import, and triggered same test on CI https://github.com/NVIDIA/NeMo/actions/runs/13323641272

@maanug-nv
Copy link
Collaborator Author

Reran after merging in base branch: https://github.com/NVIDIA/NeMo/actions/runs/13325113240

@maanug-nv maanug-nv merged commit b7253e9 into ko3n1g/build/bump-pyt-25.01 Feb 14, 2025
210 of 213 checks passed
@maanug-nv maanug-nv deleted the maanug/bump-pyt-fixes-2 branch February 14, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Changes to NeMo Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants