-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add copyright-check
workflow
#369
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few questions about how this is supposed to work. Some are a bit nitpicky but want to make sure:
- It looks like it is only supposed to check Python files. However, I see some places where init.py files are skipped. Is this intentional?
- Can we also have it check YAML/YML files and shell scripts?
- There are a couple Python files where the year is 2023 (see example) instead of 2024. Is there a way we can check for this too? I imagine when 2025 hits we will want to update too?
- There are other instances, such as here, where the copyright is even more out of date.
- Sometimes the files say
Copyright (c) 2024, NVIDIA CORPORATION. All rights reserved.
and sometimes they just sayCopyright (c) 2024, NVIDIA CORPORATION.
. Is there any way we can do an exact string match to ensure that all copyrights are identical? - Should we make sure the Dockerfile has the copyright?
Maybe best to sync with Pablo on this, he's in charge of the copyright script. |
|
||
jobs: | ||
copyright-check: | ||
uses: NVIDIA/NeMo-FW-CI-templates/.github/workflows/[email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uses: NVIDIA/NeMo-FW-CI-templates/.github/workflows/_copyright_check.yml@v0.2.0 | |
uses: NVIDIA/NeMo-FW-CI-templates/.github/workflows/_copyright_check.yml@v0.14.0 |
This version allows to check other file types too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! From NVIDIA/NeMo-FW-CI-templates#57, I am thinking we should set additional-find-args
to .yml
, .yaml
, and .sh
.
Sorry i was writing reply for this & got into something else & missed it It looks like it is only supposed to check Python files. However, I see some places where init.py files are skipped. Is this intentional? |
Thanks @pablo-garay ! A couple more comments:
|
Description
Usage
# Add snippet demonstrating usage
Checklist