Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging dictConfig, Filters and Formatters #3089

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Logging dictConfig, Filters and Formatters #3089

wants to merge 2 commits into from

Conversation

SYangster
Copy link
Collaborator

@SYangster SYangster commented Dec 3, 2024 •
edited
Loading

depends on #3081

  • Update from fileConfig to newer dictConfig API for more functionalities and customizability
  • Add JsonFormatter, ColorFormatter, FLFilter, additional handlers
  • Consolidate logging functions in log_utils

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@SYangster SYangster marked this pull request as ready for review December 5, 2024 23:05
@YuanTingHsieh YuanTingHsieh requested a review from yhwen December 6, 2024 22:50
@SYangster
Copy link
Collaborator Author

/build

@SYangster SYangster mentioned this pull request Dec 19, 2024
Draft
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesterxgchen chesterxgchen Awaiting requested review from chesterxgchen

@YuanTingHsieh YuanTingHsieh Awaiting requested review from YuanTingHsieh

@nvkevlu nvkevlu Awaiting requested review from nvkevlu

@yhwen yhwen Awaiting requested review from yhwen

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SYangster