Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Resolve multimodal model errors and update README usage instructions #1286

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

singleheart
Copy link
Contributor

@singleheart singleheart commented Nov 13, 2024

This Pull Request addresses the following changes:

  1. Bug Fix: Correct 'sample.answers' access

    • Updated cur_answer = sample.answers to cur_answer = sample.answers['value'] to fix a data access issue.
  2. Bug Fix: Apply 'mistral_custom_template' to llama

    • Set custom_chat_template=None to custom_chat_template=mistral_custom_template to resolve template-related errors in the llama3 model.
  3. Docs Update: Improve usage instructions in README.md

    • Updated usage examples to include a missing option in the megatron-energon section.

These changes aim to enhance model stability and usability while improving documentation for developers. Please review and provide feedback. Thank you!

@singleheart singleheart changed the title add omitted prepare command to multimodal README.md Fix: Resolve model errors and update README usage instructions Nov 15, 2024
@singleheart singleheart changed the title Fix: Resolve model errors and update README usage instructions Fix: Resolve multimodal model errors and update README usage instructions Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant