fix: potential panic problems in watcher.go and esource_reservation.go #879
+63
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @itsomri |
enoodle
reviewed
Jan 14, 2026
Collaborator
enoodle
left a comment
enoodle
left a comment
There was a problem hiding this comment.
Thank you! I have one question.
Comment on lines
478
to
483
| if !ok || pod == nil { | ||
| logger.Error(fmt.Errorf("unexpected watch event object type"), | ||
| "Unexpected watch event object while waiting for GPU reservation pod allocation", | ||
| "nodeName", nodeName, "name", gpuReservationPodName, "eventType", event.Type, "object", fmt.Sprintf("%T", event.Object)) | ||
| continue | ||
| } |
Collaborator
There was a problem hiding this comment.
Can this actually happen? I think 100% not because of the watcher initialization, so we can remove this.
Contributor
Author
There was a problem hiding this comment.
oh you're right. thanks for the review!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In watcher.go, We read from
ResultChan()without checking if it’s closed. If the watch ends, we may get a zero-value event and crash later (flaky tests). esource_reservation.go, We were reading fromResultChan()without anokcheck and then blindly castingevent.Objectto*v1.Pod. If the watch closes or sends an unexpected object, the binder can panic.Related Issues
Fixes #
Checklist
Breaking Changes
Additional Notes