fix: change loop continuation to break when no solution is found in job solver

[gshaibi]

No description provided.

[github-actions]

📊 Performance Benchmark Results

Comparing PR (shaibi/break-instead-of-continue) vs main branch:

goos: linux
goarch: amd64
pkg: github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions
cpu: AMD EPYC 7763 64-Core Processor                
                                    │ main-bench.txt │            pr-bench.txt            │
                                    │     sec/op     │    sec/op     vs base              │
AllocateAction_SmallCluster-4           108.3m ±  0%   108.5m ±  9%       ~ (p=0.394 n=6)
AllocateAction_MediumCluster-4          135.5m ±  1%   135.5m ±  1%       ~ (p=0.937 n=6)
AllocateAction_LargeCluster-4           223.7m ± 23%   220.6m ± 19%       ~ (p=0.699 n=6)
ReclaimAction_SmallCluster-4            103.0m ±  0%   102.9m ±  0%  -0.07% (p=0.026 n=6)
ReclaimAction_MediumCluster-4           105.7m ±  0%   105.5m ±  0%  -0.15% (p=0.026 n=6)
PreemptAction_SmallCluster-4            103.7m ±  0%   103.8m ±  0%       ~ (p=0.937 n=6)
PreemptAction_MediumCluster-4           113.4m ±  0%   113.3m ±  0%       ~ (p=0.589 n=6)
ConsolidationAction_SmallCluster-4      113.7m ±  0%   113.9m ±  0%       ~ (p=0.394 n=6)
ConsolidationAction_MediumCluster-4     204.0m ±  1%   202.0m ±  1%       ~ (p=0.180 n=6)
FullSchedulingCycle_SmallCluster-4      105.3m ±  0%   105.2m ±  0%       ~ (p=0.818 n=6)
FullSchedulingCycle_MediumCluster-4     119.3m ±  0%   118.9m ±  0%       ~ (p=0.065 n=6)
FullSchedulingCycle_LargeCluster-4      157.9m ±  1%   156.5m ±  1%  -0.85% (p=0.015 n=6)
ManyQueues_MediumCluster-4              140.5m ±  1%   139.0m ±  0%  -1.10% (p=0.009 n=6)
GangScheduling_MediumCluster-4          156.8m ±  1%   156.6m ±  1%       ~ (p=0.937 n=6)
geomean                                 130.7m         130.3m        -0.34%

                                    │ main-bench.txt │            pr-bench.txt             │
                                    │      B/op      │     B/op       vs base              │
AllocateAction_SmallCluster-4           2.116Mi ± 0%    2.115Mi ± 1%       ~ (p=0.818 n=6)
AllocateAction_MediumCluster-4          11.70Mi ± 0%    11.70Mi ± 0%       ~ (p=0.394 n=6)
AllocateAction_LargeCluster-4           41.17Mi ± 0%    41.17Mi ± 0%       ~ (p=0.699 n=6)
ReclaimAction_SmallCluster-4            867.6Ki ± 1%    867.4Ki ± 1%       ~ (p=0.818 n=6)
ReclaimAction_MediumCluster-4           2.737Mi ± 0%    2.740Mi ± 0%       ~ (p=0.180 n=6)
PreemptAction_SmallCluster-4           1011.7Ki ± 0%   1008.6Ki ± 1%       ~ (p=0.485 n=6)
PreemptAction_MediumCluster-4           3.945Mi ± 0%    3.945Mi ± 0%       ~ (p=0.394 n=6)
ConsolidationAction_SmallCluster-4      5.552Mi ± 0%    5.550Mi ± 0%       ~ (p=0.699 n=6)
ConsolidationAction_MediumCluster-4     46.66Mi ± 0%    46.66Mi ± 0%       ~ (p=0.589 n=6)
FullSchedulingCycle_SmallCluster-4      1.342Mi ± 0%    1.343Mi ± 0%       ~ (p=0.485 n=6)
FullSchedulingCycle_MediumCluster-4     6.717Mi ± 0%    6.717Mi ± 0%       ~ (p=0.699 n=6)
FullSchedulingCycle_LargeCluster-4      22.53Mi ± 0%    22.53Mi ± 0%       ~ (p=0.818 n=6)
ManyQueues_MediumCluster-4              16.16Mi ± 0%    16.16Mi ± 0%       ~ (p=0.818 n=6)
GangScheduling_MediumCluster-4          16.88Mi ± 0%    16.88Mi ± 0%       ~ (p=0.818 n=6)
geomean                                 6.228Mi         6.227Mi       -0.01%

                                    │ main-bench.txt │           pr-bench.txt            │
                                    │   allocs/op    │  allocs/op   vs base              │
AllocateAction_SmallCluster-4            35.40k ± 0%   35.40k ± 0%       ~ (p=0.851 n=6)
AllocateAction_MediumCluster-4           322.0k ± 0%   322.0k ± 0%       ~ (p=0.084 n=6)
AllocateAction_LargeCluster-4            1.386M ± 0%   1.386M ± 0%       ~ (p=0.253 n=6)
ReclaimAction_SmallCluster-4             7.896k ± 0%   7.896k ± 0%       ~ (p=0.797 n=6)
ReclaimAction_MediumCluster-4            24.54k ± 0%   24.54k ± 0%       ~ (p=0.262 n=6)
PreemptAction_SmallCluster-4             10.79k ± 0%   10.79k ± 0%       ~ (p=0.162 n=6)
PreemptAction_MediumCluster-4            37.17k ± 0%   37.17k ± 0%       ~ (p=0.574 n=6)
ConsolidationAction_SmallCluster-4       72.38k ± 0%   72.36k ± 0%       ~ (p=0.331 n=6)
ConsolidationAction_MediumCluster-4      681.0k ± 0%   681.1k ± 0%       ~ (p=0.589 n=6)
FullSchedulingCycle_SmallCluster-4       20.71k ± 0%   20.71k ± 0%       ~ (p=0.474 n=6)
FullSchedulingCycle_MediumCluster-4      172.1k ± 0%   172.1k ± 0%       ~ (p=0.738 n=6)
FullSchedulingCycle_LargeCluster-4       720.8k ± 0%   720.7k ± 0%       ~ (p=0.846 n=6)
ManyQueues_MediumCluster-4               360.1k ± 0%   360.1k ± 0%       ~ (p=0.846 n=6)
GangScheduling_MediumCluster-4           590.6k ± 0%   590.6k ± 0%       ~ (p=0.677 n=6)
geomean                                  108.9k        108.9k       -0.00%

Legend

• 📉 Negative delta = Performance improvement (faster)
• 📈 Positive delta = Performance regression (slower)
• p-value < 0.05 indicates statistically significant change

Raw benchmark data

PR branch:

goos: linux
goarch: amd64
pkg: github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions
cpu: AMD EPYC 7763 64-Core Processor                
BenchmarkAllocateAction_SmallCluster-4         	       9	 118054913 ns/op	 2237067 B/op	   35419 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 109059685 ns/op	 2219680 B/op	   35410 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 108387935 ns/op	 2218490 B/op	   35405 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 108249433 ns/op	 2217024 B/op	   35403 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 108555715 ns/op	 2216930 B/op	   35402 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 108305727 ns/op	 2217006 B/op	   35403 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 135483486 ns/op	12265119 B/op	  322003 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 135431579 ns/op	12264899 B/op	  321987 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 135134014 ns/op	12263497 B/op	  321990 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 136600178 ns/op	12272221 B/op	  321989 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 133707010 ns/op	12263326 B/op	  321990 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 135787477 ns/op	12262718 B/op	  321985 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 219789073 ns/op	43188214 B/op	 1386293 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 221343810 ns/op	43169931 B/op	 1386273 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 232584089 ns/op	43172006 B/op	 1386283 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       4	 261377893 ns/op	43170308 B/op	 1386275 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 205570435 ns/op	43178281 B/op	 1386278 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 211963531 ns/op	43172860 B/op	 1386293 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102997304 ns/op	  881551 B/op	    7869 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102915910 ns/op	  882980 B/op	    7887 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102989370 ns/op	  886269 B/op	    7896 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102947788 ns/op	  890156 B/op	    7897 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102925783 ns/op	  890200 B/op	    7897 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102922816 ns/op	  895061 B/op	    7898 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105496457 ns/op	 2869490 B/op	   24538 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105450636 ns/op	 2873429 B/op	   24539 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105704158 ns/op	 2869488 B/op	   24538 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105631486 ns/op	 2873520 B/op	   24540 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105496388 ns/op	 2873357 B/op	   24539 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105591790 ns/op	 2873464 B/op	   24540 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103697116 ns/op	 1032876 B/op	   10787 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103725018 ns/op	 1028576 B/op	   10784 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103822106 ns/op	 1036719 B/op	   10788 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103665797 ns/op	 1032474 B/op	   10786 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103779375 ns/op	 1039026 B/op	   10785 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103851879 ns/op	 1032837 B/op	   10787 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113467085 ns/op	 4133472 B/op	   37166 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113310770 ns/op	 4138429 B/op	   37171 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113229144 ns/op	 4133808 B/op	   37168 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113344570 ns/op	 4138546 B/op	   37172 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113261460 ns/op	 4138496 B/op	   37171 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113531194 ns/op	 4134066 B/op	   37170 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 113495990 ns/op	 5814872 B/op	   72327 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 113955794 ns/op	 5818664 B/op	   72370 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 114122417 ns/op	 5823071 B/op	   72408 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 113987527 ns/op	 5826582 B/op	   72357 allocs/op

Main branch:

goos: linux
goarch: amd64
pkg: github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions
cpu: AMD EPYC 7763 64-Core Processor                
BenchmarkAllocateAction_SmallCluster-4         	      10	 108378019 ns/op	 2218929 B/op	   35408 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 108557644 ns/op	 2218026 B/op	   35404 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 108312551 ns/op	 2217375 B/op	   35404 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 108083796 ns/op	 2223800 B/op	   35401 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 108275852 ns/op	 2220923 B/op	   35410 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 108409973 ns/op	 2216876 B/op	   35403 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 135952438 ns/op	12284675 B/op	  321997 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 137291441 ns/op	12264923 B/op	  321998 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 136592501 ns/op	12263673 B/op	  321995 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 135028122 ns/op	12263045 B/op	  321990 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 133781848 ns/op	12269188 B/op	  321995 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 134553653 ns/op	12266974 B/op	  321994 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 215708927 ns/op	43173019 B/op	 1386291 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 224065011 ns/op	43171788 B/op	 1386287 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 223312944 ns/op	43173132 B/op	 1386295 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 274523072 ns/op	43172572 B/op	 1386283 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 210693872 ns/op	43173027 B/op	 1386288 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 227891543 ns/op	43173308 B/op	 1386291 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 103137392 ns/op	  881380 B/op	    7867 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 103007569 ns/op	  886677 B/op	    7888 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 103007792 ns/op	  890208 B/op	    7897 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102965866 ns/op	  890332 B/op	    7898 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102949064 ns/op	  890901 B/op	    7895 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 103023880 ns/op	  886162 B/op	    7896 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105987902 ns/op	 2873512 B/op	   24539 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105626521 ns/op	 2865632 B/op	   24537 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105698675 ns/op	 2869479 B/op	   24538 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105715802 ns/op	 2869482 B/op	   24538 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105700018 ns/op	 2865455 B/op	   24536 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105765126 ns/op	 2873452 B/op	   24540 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103828203 ns/op	 1036618 B/op	   10788 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103795939 ns/op	 1036725 B/op	   10788 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103728291 ns/op	 1032791 B/op	   10787 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103708659 ns/op	 1035429 B/op	   10786 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103705943 ns/op	 1032844 B/op	   10787 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103734653 ns/op	 1036783 B/op	   10789 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113522136 ns/op	 4138434 B/op	   37171 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113385735 ns/op	 4138596 B/op	   37171 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113534526 ns/op	 4134272 B/op	   37171 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113411327 ns/op	 4134096 B/op	   37170 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113341160 ns/op	 4133924 B/op	   37169 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113179692 ns/op	 4138642 B/op	   37172 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 113901971 ns/op	 5826182 B/op	   72434 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 113647290 ns/op	 5820475 B/op	   72379 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 113646807 ns/op	 5829320 B/op	   72378 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 113559301 ns/op	 5817369 B/op	   72367 allocs/op

[github-actions]

Merging this branch will not change overall coverage

Impacted Packages	Coverage Δ	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/common/solvers	21.14% (ø)

---

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/common/solvers/job_solver.go	0.00% (ø)	70	0	70

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.