Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resize scheduler: Use the update-only mode when possible #3673

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Resize scheduler: Use the update-only mode when possible #3673

merged 1 commit into from
Jan 7, 2025

Conversation

naoyam
Copy link
Collaborator

@naoyam naoyam commented Jan 6, 2025

Just a one-line change. Using the update-only option avoids having issues like #3455

@naoyam
Copy link
Collaborator Author

naoyam commented Jan 6, 2025

!test

@naoyam naoyam added the rope label Jan 6, 2025
@naoyam naoyam requested a review from jacobhinkle January 7, 2025 00:01
jacobhinkle
jacobhinkle approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@jacobhinkle jacobhinkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@naoyam naoyam merged commit 77d3b8d into main Jan 7, 2025
46 checks passed
@naoyam naoyam deleted the resize_scheduler_update_only_when_possible branch January 7, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobhinkle jacobhinkle jacobhinkle approved these changes

Assignees
No one assigned
Labels
rope
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naoyam @jacobhinkle