Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize indexing misc bug fixes #3632

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Resize indexing misc bug fixes #3632

wants to merge 3 commits into from

Conversation

naoyam
Copy link
Collaborator

@naoyam naoyam commented Dec 22, 2024

Just minor bug fixes. Please see the inline comments.

@naoyam
Copy link
Collaborator Author

naoyam commented Dec 22, 2024

!test

for (auto inp : ir_utils::filterByType<TensorView>(expr->inputs())) {
for (auto expr : inp->domain()->allExprs()) {
std::unordered_map<TensorView*, std::vector<Resize*>> tv_resize_map;
for (auto inp : expr->inputs()) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a trivial bug that I assumed expr->inputs() are still TensorView and not TensorIndex, which is not true for predicating vectorized ops.

@@ -44,6 +44,27 @@ IndexingTraversal::IndexingTraversal(
}
resize_paths_.insert(resize);
}

// A unique expr path should be always allowed
Copy link
Collaborator Author

@naoyam naoyam Dec 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A war for a couple of issues I encountered while playing with RoPE patterns.

@naoyam naoyam marked this pull request as ready for review December 24, 2024 02:04
@naoyam naoyam requested a review from jacobhinkle December 24, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant