Resolve conflicts by recomputation #3625
Open
+363
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naoyam
force-pushed
the
resize_scheduler_recomputation
branch
from
5d1d07e to
7380a40
Compare
|
!test |
|
!test |
|
!test |
naoyam
commented
Dec 20, 2024
| @@ -133,6 +120,30 @@ bool ResizeScheduler::canScheduleCompileTime(Fusion* fusion) { | |||
| return false; | |||
| } | |||
|
|
|||
| for (auto out_tv : ir_utils::filterByType<TensorView>(fusion->outputs())) { | |||
There was a problem hiding this comment.
This check is needed since the non-exclusivity check is dropped. It was redundant before.
naoyam
commented
Dec 20, 2024
tests/cpp/test_resize.cpp
Outdated
There was a problem hiding this comment.
Most of the changes here are due to the change of the output type of getNonExclusiveResizeInfo and are just mechanical changes.
|
Found a bug. Will update soon. |
|
!test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on top of #3611
This PR resolves the conflicts found by the analysis added at #3611 by recomputing slice/pad input tensors. With this, fusions like
ResizeSchedulerTest.SliceRotateCatResidualcan be scheduled as a single kernel by the resize scheduler.Recomputation is not the only possible way to resolve conflicts. We could do, for example, cache a block of a input tensor such that multiple uses of the input can be done by just using the block. This would look more like a produce-based scheduling approach. I prototyped that approach here, but it didn't perform well for RoPE.