Enable fp8 on sm89 #3624
Merged
Enable fp8 on sm89 #3624
+23
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wujingyue
approved these changes
Dec 20, 2024
|
!test |
crcrpar
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
thank you! now I can see the same traces as in Lightning-AI/lightning-thunder#1551 on my environment with RTX6000 Ada, with a diff in thunder
Does that technically mean we only support CUDA 12+ for this feature? |
good call. I think I should conditionally relax this one, depending on the build time CUDA version. |
|
!test |
|
!test |
jjsjann123
added a commit
that referenced
this pull request
Dec 24, 2024
Fixing a version check for fp8 support. bump nvfuser version for PR #3624, Framework integration needs to guard against versions in order to decide whether to send fp8 operations to nvfuser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fp8's supported has been lifted to sm89 since PTX ISA 8.1 and later per https://docs.nvidia.com/cuda/parallel-thread-execution/