Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary NVF_API from scheduler/utils.h #3623

Merged
merged 2 commits into from
Dec 24, 2024
Merged

Remove unnecessary NVF_API from scheduler/utils.h #3623

merged 2 commits into from
Dec 24, 2024

Conversation

wujingyue
Copy link
Collaborator

No description provided.

@wujingyue
Copy link
Collaborator Author

!test

@wujingyue wujingyue requested a review from tfogal December 20, 2024 00:25
@wujingyue wujingyue marked this pull request as ready for review December 20, 2024 00:25
Copy link
Collaborator

@tfogal tfogal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Please do LD_PRELOAD such a library into thunder and run e.g. test_nvfuser.py there or something, to double-check this is fine.

@wujingyue
Copy link
Collaborator Author

!test

@wujingyue
Copy link
Collaborator Author

Please do LD_PRELOAD such a library into thunder and run e.g. test_nvfuser.py there or something, to double-check this is fine.

Do you mean the following? I failed to understand how LD_PRELOAD helps to verify.

$ LD_PRELOAD=/opt/pytorch/nvfuser/bin/libnvfuser.so pytest thunder/tests/test_nvfuser.py
================================================================================================ test session starts =================================================================================================
platform linux -- Python 3.12.3, pytest-8.1.1, pluggy-1.5.0
Test order randomisation NOT enabled. Enable with --random-order or --random-order-bucket=<bucket_type>
benchmark: 5.1.0 (defaults: timer=torch.utils.benchmark.utils.timer.timer disable_gc=False min_rounds=5 min_time=0.000005 max_time=1.0 calibration_precision=10 warmup=True warmup_iterations=100000)
rootdir: /opt/pytorch/lightning-thunder
configfile: pyproject.toml
plugins: xdist-3.6.1, timestamper-0.0.10, cov-6.0.0, timeout-2.3.1, random-order-1.1.1, hypothesis-6.122.3, mpi-0.6, benchmark-5.1.0, shard-0.1.2, typeguard-4.3.0
timeout: 900.0s
timeout method: signal
timeout func_only: False
collected 47 items
Running 47 items in this shard

thunder/tests/test_nvfuser.py ..............................ssssssssssssssss.                                                                                                                                  [100%]

=================================================================================== 31 passed, 16 skipped, 233 warnings in 11.22s ====================================================================================

@wujingyue wujingyue merged commit db3576c into main Dec 24, 2024
47 of 48 checks passed
@wujingyue wujingyue deleted the wjy/api branch December 24, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants