Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type consistency in SingleTileWithTMALoadStoreStMatrix for fusion.manage. #3613

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

csarofeen
Copy link
Collaborator

This was causing errors in one of my development branches. We need to be consistent with types that we manage with fusion when storing and getting.

@csarofeen csarofeen requested a review from naoyam December 18, 2024 16:42
@csarofeen
Copy link
Collaborator Author

Same issue as seen in #3520

@naoyam naoyam requested a review from protonu December 18, 2024 17:46
@naoyam
Copy link
Collaborator

naoyam commented Dec 18, 2024

@protonu Can you please change the type of tile_sizes to int64_t.

https://github.com/NVIDIA/Fuser/blob/main/tests/cpp/test_mma.cpp#L418

We just use int64_t for any integer data unless required to be other integer types. The cast shouldn't be necessary with this change.

@protonu
Copy link
Collaborator

protonu commented Dec 18, 2024

I'll accept this change and send a new PR to fix the type.

@protonu
Copy link
Collaborator

protonu commented Dec 18, 2024

!test

@protonu protonu merged commit a5f5e63 into main Dec 18, 2024
48 checks passed
@protonu protonu deleted the test_mma_type_fix branch December 18, 2024 22:39
@zasdfgbnm
Copy link
Collaborator

Just realized that my PR hasn’t been merged yet: #3521
I believe this PR will ensure consistency of type during cloning, and push the error to the point when we get the managed data in lowering.

protonu added a commit that referenced this pull request Dec 19, 2024
Fixing types: int -> int64_t
This is based on top of: 
#3613

---------

Co-authored-by: Christian Sarofeen <[email protected]>
@protonu
Copy link
Collaborator

protonu commented Dec 19, 2024

Just realized that my PR hasn’t been merged yet: #3521 I believe this PR will ensure consistency of type during cloning, and push the error to the point when we get the managed data in lowering.

@zasdfgbnm I missed your PR. I landed this a minute ago (#3614). You may need to rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants