Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tensor printing consistent. Implement ArgumentManager::toString. #3612

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Make tensor printing consistent. Implement ArgumentManager::toString. #3612

merged 1 commit into from
Dec 19, 2024

Conversation

csarofeen
Copy link
Collaborator

No description provided.

@csarofeen csarofeen requested a review from naoyam December 18, 2024 16:39
@csarofeen
Copy link
Collaborator Author

PR is only about adding print functions for debugging, I don't think tests need to be run as I don't think any of them would test the code changes.

@naoyam
Copy link
Collaborator

naoyam commented Dec 18, 2024

!build

naoyam
naoyam approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@naoyam naoyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

!build is always required to merge. (It's automatically done with !test)

@naoyam naoyam merged commit bce1a08 into main Dec 19, 2024
17 checks passed
@naoyam naoyam deleted the tensor_printing_argmanager branch December 19, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naoyam naoyam naoyam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csarofeen @naoyam