Host IR: make stream synchronization non blocking #3608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samnordmann
commented
Dec 18, 2024
| @@ -196,6 +197,8 @@ Communicator::Communicator( | |||
| return; | |||
| } | |||
|
|
|||
| NVFUSER_CUDA_RT_SAFE_CALL(cudaSetDevice(local_rank_)); | |||
There was a problem hiding this comment.
It's been a long time I suspected this was going to be required at some point. Anyway, this is a recommended (if not required) practice. Without it, cudaEventRecord throws cudaErrorInvalidResourceHandle in a multi-GPU scenario.
2 tasks
|
!test |
|
!test |
|
!test |
wujingyue
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Make stream synchronization non-blocking from the CPU point of view
Why
Needed for achieving overlap in
before this patch:
after this patch
How
Before this patch, the host IR
Synchronizewould callc10::synchronize()on the cuda stream, which makes the CPU blocks until stream completion. With this patch, we synchronize the current stream with a given stream through acudaEventand the APIcudaStreamWaitEvent.