Fix Flux dist ckpt loading issue #14433
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add dist loading in inference Signed-off-by: Ao Tang <[email protected]>
Signed-off-by: suiyoubi <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
orena1
reviewed
Aug 8, 2025
|
|
||
| Logs: | ||
| The function logs information about missing or unexpected keys during checkpoint loading. | ||
| """ | ||
| if do_convert_from_hf: | ||
| assert not do_convert_from_hf and load_dist_ckpt, 'do_convert_from_hf and load_dist_ckpt cannot both be true' |
There was a problem hiding this comment.
assert not do_convert_from_hf and load_dist_ckpt, 'do_convert_from_hf and load_dist_ckpt cannot both be true'
This should be
assert do_convert_from_hf and load_dist_ckpt, 'do_convert_from_hf and load_dist_ckpt cannot both be true'
Remove the not..
There was a problem hiding this comment.
Thanks @orena1 you are right
orena1
reviewed
Aug 8, 2025
orena1
suggested changes
Aug 8, 2025
Signed-off-by: Ao Tang <[email protected]>
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
cuichenx
reviewed
Aug 26, 2025
Signed-off-by: Ao Tang <[email protected]>
|
[🤖]: Hi @suiyoubi 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully. So it might be time to merge this PR or get some approvals. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add dist loading in inference
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information