Update merlin-tensorflow image to 23.08 in sagemaker example#1040
Open
edknv wants to merge 3 commits intoNVIDIA-Merlin:mainfrom
Open
Update merlin-tensorflow image to 23.08 in sagemaker example#1040edknv wants to merge 3 commits intoNVIDIA-Merlin:mainfrom
edknv wants to merge 3 commits intoNVIDIA-Merlin:mainfrom
Conversation
edknv
added
documentation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Documentation preview |
edknv
force-pushed
the
examples/sagemaker-23.06
branch
from
0f49318 to
d3fec6e
Compare
edknv
changed the title
Contributor
|
@jperez999 would you mind reviewing the changes? thanks! |
This was referenced Dec 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the sagemaker example to use the latest
merlin-tensorflow:23.08image. Due to changes in triton/systems,serve file that ships with the triton container is patched and we build our container with this patched version. Specifically, lines 143-167 that were used for disallowing multiple models are removed, and also
--model-control-mode=explicitis removed from the last line.Note also that the training script
train.pyis updated to reflect the latest changes in the nvtabular workflow.