Fix illegal memory access for textureless meshes#81
Open
STREM-hexagon wants to merge 1 commit intoNVIDIA-ISAAC-ROS:mainfrom
Open
Fix illegal memory access for textureless meshes#81STREM-hexagon wants to merge 1 commit intoNVIDIA-ISAAC-ROS:mainfrom
STREM-hexagon wants to merge 1 commit intoNVIDIA-ISAAC-ROS:mainfrom
Conversation
|
Thanks for catching and fixing this, it looks good to me. We will include this fix in the next patch for release-3.2. |
yuanknv
approved these changes
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a dummy texture for textureless meshes the way it is done so far causes illegal memory accesses if
num_vertices * num_views > 1920 * 1080. To avoid this, this PR allocates a vertex color array instead of a texture and uses broadcasting to correctly access the colors in the renderer.